Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Backoff For Pruned Peers #473

Merged
merged 2 commits into from Feb 7, 2022
Merged

Add Backoff For Pruned Peers #473

merged 2 commits into from Feb 7, 2022

Conversation

nisdas
Copy link
Contributor

@nisdas nisdas commented Feb 7, 2022

This PR resolves the issue described in #367.

  • To prevent unnecessary penalties due to eager re-grafting of peers, we now add a backoff when leaving a topic and pruning the respective peers from our topic mesh.
  • Adds in a regression test for this case.

@nisdas nisdas mentioned this pull request Feb 7, 2022
Closed
vyzo
vyzo approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vyzo vyzo merged commit e02b347 into libp2p:master Feb 7, 2022
@nisdas nisdas deleted the backOffWhenPruning branch February 7, 2022 14:09
@nisdas nisdas mentioned this pull request Feb 8, 2022
Merged
2 tasks
@BigLep BigLep linked an issue Apr 26, 2022 that may be closed by this pull request
Gossipsub Backoffs not stored in GossipSubRouter::sendPrune #367
Closed
@vyzo vyzo mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gossipsub Backoffs not stored in GossipSubRouter::sendPrune
2 participants
@nisdas @vyzo