New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message rebroadcast hours later #529

Open

gvelez17 opened this issue Mar 24, 2023 · 1 comment

gvelez17 commented Mar 24, 2023

While investigating a Pubsub Flood: https://github.com/libp2p/go-libp2p-pubsub/issues/524 in which the same sequence number appears multiple times, we have seen cases where the same From and Seqno appear as much as 6 hours apart.

This exceeds most reasonable cache sizes. Is there a way to prevent this behavior?

Collaborator

vyzo commented Mar 24, 2023

We recently introduced default validators with an implementation that rejects old sequence numbers.

It can be improved (planned follow up to use a sack bitfield for tracking the last 64 msgs), but it can solve your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment