Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message buffer filled log message should be an error message #472

Open
rllola opened this issue Feb 2, 2022 · 1 comment
Open

Message buffer filled log message should be an error message #472

rllola opened this issue Feb 2, 2022 · 1 comment

Comments

@rllola
Copy link

rllola commented Feb 2, 2022

I have encounter the case where I filled the buffer faster than I was reading it and messages were dropped. Took me a while to figure out because I didn't see any errors.

I noticed the INFO message after a while (see https://github.com/libp2p/go-libp2p-pubsub/blob/master/pubsub.go#L928). It should be made more evident to people that messages are being dropped to avoid confusion by showing ERROR or at least a WARN tag in the logs.

@lthibault
Copy link
Contributor

It seems to me this is definitely not an ERROR-level event, since it does not invalidate the state of the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants