Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gossipsub subscription filter bug #449

Open
synzhu opened this issue Aug 27, 2021 · 0 comments
Open

Fix gossipsub subscription filter bug #449

synzhu opened this issue Aug 27, 2021 · 0 comments

Comments

@synzhu
Copy link
Contributor

synzhu commented Aug 27, 2021

As discussed here, there is a bug in the gossipsub implementation that causes messages to be sent in certain cases to peers even if those peers should be blocked by subscription filters.

bors bot added a commit to onflow/flow-go that referenced this issue Sep 24, 2021
1210: Subscription filter r=smnzhu a=smnzhu

Implements subscription filter. Will not work 100% until libp2p/go-libp2p-pubsub#449 is fixed.

https://github.com/dapperlabs/flow-go/issues/5801

Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>
Co-authored-by: vishal <1117327+vishalchangrani@users.noreply.github.com>
bors bot added a commit to onflow/flow-go that referenced this issue Sep 25, 2021
1210: Subscription filter r=smnzhu a=smnzhu

Implements subscription filter. Will not work 100% until libp2p/go-libp2p-pubsub#449 is fixed.

https://github.com/dapperlabs/flow-go/issues/5801

Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>
Co-authored-by: vishal <1117327+vishalchangrani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant