Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

remove metadata interning #185

Merged
merged 1 commit into from
Dec 2, 2021
Merged

remove metadata interning #185

merged 1 commit into from
Dec 2, 2021

Conversation

marten-seemann
Copy link
Contributor

Now that we're garbage collection disconnected peers, the memory usage of saving N times the AgentVersion and ProtocolVersion should be negligible, if N is O(1000). Otherwise, we'd also have to implement garbage collection of the interned map.

vyzo
vyzo approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@marten-seemann marten-seemann merged commit c07b052 into master Dec 2, 2021
@marten-seemann marten-seemann deleted the remove-interning branch December 2, 2021 12:10
@marten-seemann marten-seemann mentioned this pull request Dec 4, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marten-seemann @vyzo