This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
feat: remove unused metrics #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops the opensensus dependency. Nobody uses this, from what I can tell. fixes #58
|
What about https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/metrics.go? Note: I don't understand why we use OpenCensus there. |
|
We were trying to switch over to OpenCensus at one point. I think that's still on the roadmap.
I just want to remove the dependency from the core interfaces. go-ipfs will still depend on it, but users can pull in go-libp2p-core (e.g., because they need some random type) without it.
|
marten-seemann
approved these changes
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the opensensus dependency. Nobody uses this, from what I can tell.
fixes #58