Build instructions do not work, AM_GNU_GETTEXT #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dependency list to readme
nirs
reviewed
Feb 26, 2024
| @@ -21,6 +21,9 @@ the source tree. | |||
| BUILDING FROM SOURCE | |||
| ====================================================================== | |||
|
|
|||
| Install dependencies | |||
| sudo apt install build-essential ca-certificates gcc make automake libtool libguestfs-tools libguestfs-dev libnbd-dev gettext libpcre2-dev libvirt-dev libxml2-dev libjansson-dev libosinfo-1.0-dev ocaml-findlib libvirt-ocaml-dev libguestfs-ocaml-dev libnbd-ocaml-dev | |||
There was a problem hiding this comment.
The commit message is not clear - what do you mean by "AM_GNU_GETTEXT"? maybe you mean that the gettext package was missing?
But I think it will be better to use the equivalent of dnf builddep for apt based systems, installing the needed packages based on the package metadata. With this you get all the packages in most cases and there is no need to maintain this packages list.
If we go with actual package list, it should be sorted and formatted as one package per line:
sudo apt install \
build-essential \
ca-certificates \
gcc \
...
There was a problem hiding this comment.
IMHO better instructions would be just:
apt-get build-dep virt-v2v
apt-get install autoconf automake libtool-bin gettext
| * OCaml oUnit2 |
nirs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dependency list to readme
Fixes #24