Bump libgit2 to v0.28.2 and backport some fixes #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we call the block, an exception or even a call to `break` would cause us to
unwind the stack and skip any resource freeing that we may have. The solution is
to call `rb_protect` which will let us catch the exception and raise whenever we
need to.
Doing this as part of a `git_status_foreach` is unnecessarily awkward so move to
iterating over the status list ourselves and free the entry list as soon as we
notice there was an exception.
For example, this program will consume memory
indefinitely:
require 'rugged'
repo = Rugged::Repository.new ARGV[0]
loop do
repo.status do |file, status_data|
break
end
end
Thanks to Aaron Patterson for discovering this and the original hacky fix.
Not doing so means an exception or even a break will jump over us and not give us the opportunity to free the resources we've allocated.
I use strict compiler flags on my version of Ruby. Since the callback signature didn't match correctly, compilation would fail. This fixes the nogvl callback signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It includes a couple of leaks in case of error and a warning fix which could make you fail to compile if you have strict mode.