Remove constructor with preFill argument from Pool #6117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I've realised that the constructor based mechanisms that #5773 introduced to prefill a Pool is bad and should be removed (we can keep calling
fill()
after instantiation).Calling a protected method (
newObject()
) on the constructor is an anti pattern and can cause state consistency issues as the object may not have been fully initialized. A simple example can be seen onParticleEffectPool
in which if we use the constructor passingpreFill()
astrue
,newObject()
will be called beforeeffect
has been set throwing aNullPointerException
.I should have seen this issue before, sorry for that :(