New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential resize issue in 1.9.0 on iOS related to subviews. #3789
Comments
I believe this may be caused by this (mine) PR which moved resize to be called on subview layout. If I understand the problem correctly, it should be possible to fix it by caching last values with which I'll look into it after #3709. Can you please provide SSCCE of application with banner ad view for testing and verifying the fix? |
Happen the same to me, in version 1.8.0 is everything working fine, now with 1.9.0 on resize IOS the game crash, I disabled admob and still happening.
Thx |
That stack trace points to your code and without seeing it I can't tell what is broken and what it is related to. I suggest taking this to IRC or forums until it is certain that this is an issue with libGDX. Btw. Use triple-backticks for block-formatted code ( |
Thx for the tips Darkyenus. I will do that. |
This is a breaking change, but makes the API consistent with core. Fixes libgdx#3789 (resize() being triggered with same dimensions) Fixes touch mapping on older iOS versions when screen is rotated
* Change how retina resolutions are handled This is a breaking change, but makes the API consistent with core. Fixes #3789 (resize() being triggered with same dimensions) Fixes touch mapping on older iOS versions when screen is rotated * Update CHANGES Co-authored-by: obigu <torinthechosen@gmail.com> Co-authored-by: Benjamin Schulte <MrStahlfelge@users.noreply.github.com>
This may be by design and I've not looked into it too thoroughly as I've worked around the problem but thought I should draw attention to it.
I'm using AdMob banners, and when the screen was resized I destroyed the old AdView and created a new one to handle orientation change. When I upgraded to 1.9.0 the iOS version went into a resize loop when I started the game, where resize was being called on every game loop.
The iOS version now calls resize when a subview is added, this lead my code to destroy and recreate my adview, which then caused resize to be called again on the next loop.
The thing that makes this look like it might be a bug is that if I returned to the home screen of the iPad and back to the game, this stopped happening.
The text was updated successfully, but these errors were encountered: