You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pretty much all of the guards for FFI_CLOSURES and FFI_NATIVE_RAW_API test with #if so it's possible to explicitly say "We don't support this" with #define FFI_CLOSURES 0. On the other hand, the tests for FFI_GO_CLOSURES mostly test with #ifdef so #define FFI_GO_CLOSURES 0 is treated as a signal that they are supported. Same with FFI_TARGET_SPECIFIC_VARIADIC. It would be nice if this were consistent. I think using #if is better so targets can explicitly declare that they don't support things.
The text was updated successfully, but these errors were encountered:
Pretty much all of the guards for
FFI_CLOSURES
andFFI_NATIVE_RAW_API
test with#if
so it's possible to explicitly say "We don't support this" with#define FFI_CLOSURES 0
. On the other hand, the tests forFFI_GO_CLOSURES
mostly test with#ifdef
so#define FFI_GO_CLOSURES 0
is treated as a signal that they are supported. Same withFFI_TARGET_SPECIFIC_VARIADIC
. It would be nice if this were consistent. I think using#if
is better so targets can explicitly declare that they don't support things.The text was updated successfully, but these errors were encountered: