Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target flags sometimes tested with #if other times with #ifdef. #762

Open
hoodmane opened this issue Jan 27, 2023 · 0 comments
Open

Target flags sometimes tested with #if other times with #ifdef. #762

hoodmane opened this issue Jan 27, 2023 · 0 comments

Comments

@hoodmane
Copy link
Contributor

Pretty much all of the guards for FFI_CLOSURES and FFI_NATIVE_RAW_API test with #if so it's possible to explicitly say "We don't support this" with #define FFI_CLOSURES 0. On the other hand, the tests for FFI_GO_CLOSURES mostly test with #ifdef so #define FFI_GO_CLOSURES 0 is treated as a signal that they are supported. Same with FFI_TARGET_SPECIFIC_VARIADIC. It would be nice if this were consistent. I think using #if is better so targets can explicitly declare that they don't support things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant