Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest commit causing issues building code #917

Closed
kjbass opened this issue Dec 2, 2019 · 5 comments
Closed

Latest commit causing issues building code #917

kjbass opened this issue Dec 2, 2019 · 5 comments

Comments

@kjbass
Copy link

kjbass commented Dec 2, 2019

# github.com/lib/pq
../../lib/pq/conn_go18.go:213:21: not enough arguments in call to st.cn.cancel
	have ()
	want (context.Context)

Above is error returned when executing a go get for this. go get github.com/lib/pq

@masonkirchner
Copy link

Seeing the same issue

@arhelgens
Copy link

I am seeing the same issue with Docker

Building in the golang:1.12.7-alpine container

FROM golang:1.12.7-alpine as build
RUN apk add --no-cache git && apk add --no-cache build-base && go get github.com/pkg/errors && go get github.com/gorilla/mux && go get github.com/lib/pq

@muhlemmer
Copy link

pq/conn_go18.go

Line 213 in a2bfbdf

return st.cn.cancel()

It was introduced in today merge of #768

@muhlemmer
Copy link

Looks like its already reverted: #918. My builds are working again 👍

@kjbass
Copy link
Author

kjbass commented Dec 2, 2019

Works for me also, I'll mark it as closed.

@kjbass kjbass closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants