Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: add SQLState #1080

Merged
merged 1 commit into from May 11, 2022
Merged

error: add SQLState #1080

merged 1 commit into from May 11, 2022

Conversation

drakkan
Copy link
Contributor

@drakkan drakkan commented May 6, 2022

SQLState is also implemented in pgx.
This change allows to get the SQL state without importing lib/pq, see
for example here:

https://github.com/cockroachdb/cockroach-go/blob/e1659d1d3580897bce4cea1181724872d792ce53/crdb/tx.go#L232

to understand why it is useful

SQLState is also implemented in pgx.
This change allow to get the SQL state without importing lib/pq, see
for example here

https://github.com/cockroachdb/cockroach-go/blob/e1659d1d3580897bce4cea1181724872d792ce53/crdb/tx.go#L232
drakkan referenced this pull request in siepkes/sftpgo May 7, 2022
pq recommend using pgx since pq itself is in maintenance mode. pgx
offers support for things like client-side failover.
@rafiss rafiss merged commit 30d9faf into lib:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants