Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build in android #1060

Merged
merged 2 commits into from Nov 7, 2021
Merged

Fix build in android #1060

merged 2 commits into from Nov 7, 2021

Conversation

ian4hu
Copy link
Contributor

@ian4hu ian4hu commented Oct 13, 2021 •
edited

Now build it on android with error:

# github.com/lib/pq
vendor/github.com/lib/pq/user_posix.go:13:6: userCurrent redeclared in this block
	/home/builder/.termux-build/algernon/build/src/github.com/xyproto/algernon/vendor/github.com/lib/pq/user_other.go:8:29: previous declaration

Because that GOOS=android implies GOOS=linux see https://pkg.go.dev/cmd/go#hdr-Build_constraints

Using GOOS=android matches build tags and files as for GOOS=linux in addition to android tags and files.

Fixes #1051

@ian4hu
Copy link
Contributor Author

ian4hu commented Oct 13, 2021

See #1051

@otan otan merged commit 6a102c0 into lib:master Nov 7, 2021
@Sirmorrison Sirmorrison mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GOOS=android build error
2 participants
@ian4hu @otan