implement gh actions workflow #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelshobbs
force-pushed
the
feature/gh-actions
branch
from
f0cc6e8
to
8980c1c
Compare
|
i'm no expert either, but my guess is those certificates have to be regenerated. maybe worth following https://www.postgresql.org/docs/current/ssl-tcp.html. this is looking awesome btw! |
michaelshobbs
force-pushed
the
feature/gh-actions
branch
from
8980c1c
to
b81abde
Compare
maddyblue
reviewed
Sep 2, 2021
|
once this is merged, i'll update #1047 with these commits |
|
this is awesome, cheers buddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1047 (comment)
the
TestSSLClientCertificatesfails on postgres 13 & 12 withssl_test.go:269: remote error: tls: bad certificatebut the other postgres versions seem to work.EDIT: also
TestSSLVerifyFullfails on golang 1.17 withssl_test.go:104: x509: certificate relies on legacy Common Name field, use SANs instead. From what I can tell, they removed theGODEBUG=x509ignoreCN=0flag.