From 20276536a923cf1ecb54899c80046104b7ba8692 Mon Sep 17 00:00:00 2001 From: Luis GG Date: Tue, 26 Apr 2022 13:06:50 -0300 Subject: [PATCH] Update hostCompatibleBucketName doc to reflect #848 changes --- service/s3/internal/customizations/update_endpoint.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/service/s3/internal/customizations/update_endpoint.go b/service/s3/internal/customizations/update_endpoint.go index 209e554ef1e..c4849f4a3d0 100644 --- a/service/s3/internal/customizations/update_endpoint.go +++ b/service/s3/internal/customizations/update_endpoint.go @@ -35,7 +35,6 @@ type UpdateEndpointParameterAccessor struct { // UpdateEndpointOptions provides the options for the UpdateEndpoint middleware setup. type UpdateEndpointOptions struct { - // Accessor are parameter accessors used by the middleware Accessor UpdateEndpointParameterAccessor @@ -256,8 +255,9 @@ func removeBucketFromPath(u *url.URL, bucket string) { } // hostCompatibleBucketName returns true if the request should -// put the bucket in the host. This is false if S3ForcePathStyle is -// explicitly set or if the bucket is not DNS compatible. +// put the bucket in the host. This is if the bucket is not +// DNS compatible of if the client has and EndpointResolver with +// its HostnameImmutable property set to true func hostCompatibleBucketName(u *url.URL, bucket string) bool { // Bucket might be DNS compatible but dots in the hostname will fail // certificate validation, so do not use host-style.