Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go1.22: Remove loop variable lexical rebindings after a future gopls update #7454

Open
pgporada opened this issue Apr 24, 2024 · 0 comments
Open

go1.22: Remove loop variable lexical rebindings after a future gopls update #7454

pgporada opened this issue Apr 24, 2024 · 0 comments

Comments

@pgporada
Copy link
Member

There is a bug in gopls that requires us to rebind the loop variable if/when we run subtests in parallel such as what I did in #7438 and #7452.

Once a newer version of gopls has been released and our tooling begins using it, let's remove occurrences of testCases := testCases, tc:=tc, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgporada