Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP codecov: update to v3 action #778

Closed
wants to merge 1 commit into from

Conversation

imirkin
Copy link
Contributor

@imirkin imirkin commented Jul 19, 2022

v1 is deprecated and no longer works. Update to v3.

Fixes #743

v1 is deprecated and no longer works. Update to v3.

Fixes lestrrat-go#743
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop/v2@851d370). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop/v2     #778   +/-   ##
=============================================
  Coverage              ?   70.91%           
=============================================
  Files                 ?       90           
  Lines                 ?    13173           
  Branches              ?        0           
=============================================
  Hits                  ?     9341           
  Misses                ?     3016           
  Partials              ?      816           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851d370...ea29781. Read the comment docs.

@imirkin
Copy link
Contributor Author

imirkin commented Jul 19, 2022

Hmmmm ... unclear if this helps. The earlier PRs also had accurate numbers for that PR but not the baseline... also should probably only upload a single tag's worth of coverage.

Please consider this WIP.

@imirkin imirkin changed the title codecov: update to v3 action WIP codecov: update to v3 action Jul 19, 2022
@imirkin
Copy link
Contributor Author

imirkin commented Jul 19, 2022

Ah no ... looks like v1 isn't as gone as the docs make it out to be. For some reason it's looking at the wrong thing for the parent, probably needs some settings in codecov but I probably am not allowed to do it or can't figure out how. Or ... something else. In any case, no clue how to fix.

@imirkin imirkin closed this Jul 19, 2022
@lestrrat
Copy link
Collaborator

Me neither! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] Fix codecov
3 participants