Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do away with draining, discard error if write fails #423

Merged
merged 1 commit into from Jul 30, 2021
Merged

Conversation

lestrrat
Copy link
Collaborator

@lestrrat lestrrat commented Jul 30, 2021

On second thought this is way more efficient than queuing up errors.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #423 (48c0d53) into main (c76a3f5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   69.90%   69.93%   +0.03%     
==========================================
  Files          80       80              
  Lines        9250     9238      -12     
==========================================
- Hits         6466     6461       -5     
+ Misses       1930     1924       -6     
+ Partials      854      853       -1     
Impacted Files Coverage Δ
jwk/refresh.go 77.73% <100.00%> (+0.53%) ⬆️
jwk/jwk.go 59.94% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76a3f5...48c0d53. Read the comment docs.

@lestrrat lestrrat merged commit 52266f3 into main Jul 30, 2021
@lestrrat lestrrat deleted the gh-420-fix branch July 30, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants