Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PhantomJS stuff #3772

Open
jimmywarting opened this issue Jan 8, 2023 · 5 comments · May be fixed by #3809
Open

Remove PhantomJS stuff #3772

jimmywarting opened this issue Jan 8, 2023 · 5 comments · May be fixed by #3809

Comments

@jimmywarting
Copy link

I saw this and though, nobody is using phantomjs. it's a headless browser that no real user is using. it was based on webkit and the development have been discontinued. think you should remove this kind of things and instead use something like puppeteer or something.

// only really needed for phantom
function bind(func, thisArg) {
const curryArgs = Array.prototype.slice.call(arguments, 2);
return function() {
const args = curryArgs.concat(Array.prototype.slice.call(arguments, 0));
return func.apply(thisArg, args);
};
}

PhantomJS is depricated and should not be used anymore.

@matthew-dean
Copy link
Member

Current tests use mocha-headless-chrome which uses Puppeteer, so @jimmywarting feel free to make a PR.

@gadzbi123
Copy link

gadzbi123 commented May 17, 2023

This issue can be closed in reference to #3792

@IAmRiteshKoushik
Copy link

Is this issue still up-for-grabs or has it been resolved ? If someone could help me out here a bit, then I would like to take up the issue and try resolving it.

@TusharP05
Copy link

is someone working on this? I will be happy to take up this issue and contribute.

@iChenLei iChenLei linked a pull request Jul 14, 2023 that will close this issue
3 tasks
@Groot-2001
Copy link

Hey @matthew-dean , I would like to work on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants