Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request with node-fetch #3505

Closed
sntran opened this issue May 28, 2020 · 2 comments
Closed

Replace request with node-fetch #3505

sntran opened this issue May 28, 2020 · 2 comments

Comments

@sntran
Copy link

sntran commented May 28, 2020

Even though request is one of the optionalDepedencies, it is still installed through normal npm install, and not many people will remember to use the --no-optional flag.

I did a search and request is only used in lib/less-node/url-file-manager.js. In that case, it's probably leaner to switch to something like node-fetch. request is 3.84MB installed while node-fetch is only 153KB installed.

I would be happy to create a PR for it if it's worth considering.

@jburson
Copy link

jburson commented Jun 11, 2020

Also, request generates warnings for all consumers:
warning less > request@2.88.2: request has been deprecated, see request/request#3142

@matthew-dean
Copy link
Member

This has been replaced with native-request via this PR: #3501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants