Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering maps values omits following '!important' statement #3430

Closed
splosch opened this issue Sep 5, 2019 · 6 comments
Closed

Rendering maps values omits following '!important' statement #3430

splosch opened this issue Sep 5, 2019 · 6 comments

Comments

@splosch
Copy link

splosch commented Sep 5, 2019

An !important statement following maps value retrieval is rendering the values without !important

Reproducible on http://lesscss.org/less-preview/

LESS:

@colors : {
  primary: blue;
  secondary: green;
}

.foo {
  color: @colors[primary] !important;
}

Current Result:

.foo {
  color: blue;
}

Expected Result:

.foo {
  color: blue !important;
}

Workaround:

.bar {
  color: @colors[primary] ~"!important";
}
@matthew-dean
Copy link
Member

@splosch Yup, clear bug. I can see how that would happen.

@batchunag
Copy link
Contributor

Hi @matthew-dean. I'm interested in this ticket, is there anyone working on this?

@matthew-dean
Copy link
Member

@batchunag Not to my knowledge. If you wanna grab it, go for it.

@batchunag
Copy link
Contributor

Cool. Thanks

batchunag added a commit to batchunag/less.js that referenced this issue Sep 10, 2019
@batchunag
Copy link
Contributor

Please review the code changes.

@batchunag
Copy link
Contributor

Hi @matthew-dean, is there anything I can do for this PR code? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants