Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running lerna publish on Github updates pnpm-lock.yaml quotes #3981

Open
atomrevival opened this issue Mar 25, 2024 · 0 comments
Open

Running lerna publish on Github updates pnpm-lock.yaml quotes #3981

atomrevival opened this issue Mar 25, 2024 · 0 comments

Comments

@atomrevival
Copy link

Current Behavior

Upon generating a pnpm-lock file locally, scoped packages are wrapped in a singe quote ' ' whereas after publishing, the updated lockfile returns it in double quotes " ".

Expected Behavior

The lockfile should only be updated with the new versions, not the linting.

Steps to Reproduce

  1. Use pnpm
  2. Install packages locally
  3. Check that the pnpm-lock.yaml has single quotes
  4. Use lerna publish in Github Actions
  5. The updated pnpm-lock.yaml file has double quotes

This issue may not be prioritized if details are not provided to help us reproduce the issue.

Failure Logs / Configuration

lerna.json

{
  "$schema": "node_modules/lerna/schemas/lerna-schema.json",
  "tagVersionPrefix": "",
  "version": "independent",
  "npmClient": "pnpm",
  "packages": ["packages/components/*"],
  "command": {
    "version": {
      "conventionalCommits": true
    },
    "publish": {
      "message": "chore(release): publish",
      "conventionalCommits": true
    }
  }
}

lerna-debug.log

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Environment

Environment info:

Local setup:

System:
OS: macOS 14.3.1
CPU: (12) arm64 Apple M3 Pro
Binaries:
Node: 21.6.1 - ~/.nvm/versions/node/v21.6.1/bin/node
Yarn: 1.22.21 - ~/.nvm/versions/node/v21.6.1/bin/yarn
npm: 10.2.4 - ~/.nvm/versions/node/v21.6.1/bin/npm
Utilities:
Git: 2.39.3 - /usr/bin/git
npmPackages:
lerna: ^8.1.2 => 8.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant