Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lerna publish: issuing a WARN for private packages do not make sense #3978

Open
christian-weiss-df opened this issue Mar 20, 2024 · 0 comments
Labels
accepting-prs We would gladly receive a PR to resolve this issue type: bug

Comments

@christian-weiss-df
Copy link

Current Behavior

on "npx lerna publish" the cli (lerna cli v8.1.2) is issuing a WARN like this:

lerna WARN Unable to determine published version, assuming "my-package-here" unpublished.

But this package.json is set to:

private=true

Expected Behavior

There is no need to determ the version number of this package from remote npm package registry (github in my case).
A WARN is meaningless as the publishing process for this package will be skipped anyways.

On the other side a INFO about all packages which where skipped due to "private=true" would be better then just finishing the publishing process as success, without giving a hint, that something was skipped (by a good reason).

Steps to Reproduce

see above

Failure Logs / Configuration

package.json is set to:

private=true

lerna.json:

{
  "$schema": "node_modules/lerna/schemas/lerna-schema.json",
  "version": "independent",
  "npmClient": "npm",
  "command": {
    "publish": {
      "registry": "https://npm.pkg.github.com"
    }
  }
}

Environment

npx lerna --version
8.1.2

node --version
v18.12.1

npm --version
9.8.1

npx --version
9.8.1
@fahslaj fahslaj added the accepting-prs We would gladly receive a PR to resolve this issue label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting-prs We would gladly receive a PR to resolve this issue type: bug
Projects
None yet
Development

No branches or pull requests

2 participants