Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): recover from network failure #3513

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jan 26, 2023

Description

Catches the EPUBLISHCONFLICT error from npm when a version already exists. In this case, Lerna assumes that you have already published the package.

Motivation and Context

This allows lerna publish from-git to be idempotent. If one or more packages fail to publish, then you can rerun lerna publish from-git to publish the packages that failed.

#455

How Has This Been Tested?

This has been tested manually and is covered by e2e tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj changed the title recover from failed from-git publish recover from failed publish Jan 26, 2023
@fahslaj fahslaj marked this pull request as ready for review January 27, 2023 19:06
@fahslaj fahslaj changed the title recover from failed publish feat(publish): recover from network failure Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants