Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): add explicit nx dependency #3486

Merged
merged 1 commit into from Jan 5, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jan 5, 2023

Description

Adds an explicit dependency on Nx to @lerna/run.

Motivation and Context

#3481

How Has This Been Tested?

This has been tested manually against the repo from issue #3481 as well as a barebones reproduction workspace.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review January 5, 2023 17:48
@JamesHenry JamesHenry merged commit 7e39397 into lerna:main Jan 5, 2023
@fahslaj fahslaj deleted the 3481-include-nx-dep-for-lerna-run branch January 5, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants