Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): recognize .prettierignore when formatting files #3482

Merged
merged 5 commits into from Jan 5, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jan 4, 2023

Description

Checks to see if a file should be ignored by prettier before formatting it at the end of lerna version.

Motivation and Context

This will allow files that are automatically updated via lerna version to be ignored by prettier, such as lockfiles and package.json files.
#3476

How Has This Been Tested?

This has been tested manually and covered by e2e tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj force-pushed the 3476-recognize-prettier-ignore branch 2 times, most recently from 4be69cb to 46df607 Compare January 4, 2023 22:04
@fahslaj fahslaj marked this pull request as ready for review January 4, 2023 23:16
@JamesHenry JamesHenry merged commit 4e2c7a9 into lerna:main Jan 5, 2023
@fahslaj fahslaj deleted the 3476-recognize-prettier-ignore branch January 5, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants