Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): add the other format changelogPreset can assume #3441

Merged
merged 1 commit into from Dec 13, 2022

Conversation

vhoyer
Copy link
Contributor

@vhoyer vhoyer commented Nov 28, 2022

This references the version 2.2.0 from the following repository. https://github.com/conventional-changelog/conventional-changelog-config-spec

Description

Motivation and Context

The current schema only allow for a string based "changelogPreset", but lerna also supports an object syntax for this property.

How Has This Been Tested?

Linked the proposed changes to one of my monorepos' lerna.json by adding a $schema at the beginning of the file, it works.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JamesHenry JamesHenry merged commit d286973 into lerna:main Dec 13, 2022
@JamesHenry
Copy link
Member

Thank you @vhoyer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants