Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): detect target configuration in package.json files #3432

Merged
merged 6 commits into from Nov 29, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Nov 18, 2022

Detect custom, package-specific Nx configuration in package.json files.

Description

Updates Lerna run to consider Nx configuration within package.json files when determining whether or not to tell Nx mimic Lerna default behavior regarding including project dependencies in running tasks.

Motivation and Context

#3407

How Has This Been Tested?

An e2e test has been added to cover this case. This has also been tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review November 18, 2022 16:54
@JamesHenry JamesHenry merged commit 798aae1 into lerna:main Nov 29, 2022
rrhodes pushed a commit to rrhodes/lerna that referenced this pull request Jan 3, 2023
@fahslaj fahslaj deleted the fix/project-specific-config branch January 5, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants