Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): support inconsistent workspace prefix usage #3413

Merged

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Nov 7, 2022

Adds a guard to prevent interpreting all local dependencies as workspace links when a single workspace link is detected.

Motivation and Context

#3412

Lerna was assuming that if any one package is linked with the workspace: prefix, then all packages in the workspace are linked that way. This change allows workspaces to be more flexible and iterative when adopting the workspace: prefix standard. After this PR, lerna publish will no longer break when publishing a package with inconsistent usage of the workspace prefix for linking local dependencies.

How Has This Been Tested?

This has been tested manually and covered by an e2e test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj changed the title fix(publish): support inconsistent workspace prefixes fix(publish): support inconsistent workspace prefix usage Nov 7, 2022
@fahslaj fahslaj marked this pull request as ready for review November 7, 2022 17:11
@fahslaj fahslaj merged commit da2274b into lerna:main Nov 7, 2022
@fahslaj fahslaj deleted the fix/3412-support-inconsistent-workspace-prefix branch November 7, 2022 17:15
rrhodes pushed a commit to rrhodes/lerna that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants