Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): remove workspace prefix on publish #3397

Merged
merged 5 commits into from Nov 1, 2022
Merged

fix(publish): remove workspace prefix on publish #3397

merged 5 commits into from Nov 1, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Oct 28, 2022

Properly removes the workspace prefix with lerna publish.

Description

Pass a flag to the package graph when updating for a publish so that workspace prefixes are properly overwritten.

Motivation and Context

#3393

How Has This Been Tested?

An e2e test has been added to cover this case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj force-pushed the 3393-remove-workspace-prefix-publish branch 4 times, most recently from 21252e9 to dca1267 Compare October 31, 2022 17:02
@fahslaj fahslaj marked this pull request as ready for review October 31, 2022 17:24
@fahslaj fahslaj force-pushed the 3393-remove-workspace-prefix-publish branch from 54d3e4c to d463a16 Compare October 31, 2022 18:19
@fahslaj fahslaj force-pushed the 3393-remove-workspace-prefix-publish branch from d463a16 to 2dfe55e Compare November 1, 2022 14:53
@fahslaj fahslaj assigned JamesHenry and unassigned JamesHenry Nov 1, 2022
@fahslaj fahslaj enabled auto-merge (squash) November 1, 2022 16:08
@fahslaj fahslaj merged commit 1f0e546 into lerna:main Nov 1, 2022
@fahslaj fahslaj deleted the 3393-remove-workspace-prefix-publish branch November 1, 2022 16:46
rrhodes pushed a commit to rrhodes/lerna that referenced this pull request Jan 3, 2023
@fahslaj
fix(publish): remove workspace prefix on publish (lerna#3397)
9e47d79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fahslaj @JamesHenry