Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): missing fs-extra dependency declaration #3332

Merged
merged 1 commit into from Sep 19, 2022

Conversation

fupengl
Copy link
Contributor

@fupengl fupengl commented Sep 17, 2022

Description

The fs-extra dependency is missing when lerna run is executed.
This dependency must be declared and installed

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fupengl fupengl changed the title fix: missing dependency declaration fix(run): missing fs-extra dependency declaration Sep 18, 2022
@JamesHenry
Copy link
Member

JamesHenry commented Sep 19, 2022

Thanks @fupengl, but what issue/error have you actually observed please?

@lerna/run depends on @lerna/profiler which already depends on fs-extra so the dependency is already transitively available.

I understand the desire for correctness, and that's fine, but it would first be good to understand if this actually caused any issues in practice

@fupengl
Copy link
Contributor Author

fupengl commented Sep 19, 2022

Thanks @fupengl, but what issue/error have you actually observed please?

@lerna/run depends on @lerna/profiler which already depends on fs-extra so the dependency is already transitively available.

I understand the desire for correctness, and that's fine, but it would first be good to understand if this actually caused any issues in practice

If the non-dependency upgrade is used, the module will still not be found. It is recommended to add it. The currently added version is the same as the version number that @lerna/profiler depends on, and there will be no additional impact.

@fupengl fupengl closed this Sep 19, 2022
@fupengl
Copy link
Contributor Author

fupengl commented Sep 19, 2022

My problem is that the dependencies installed through pnpm show that the package cannot be found when executing the run command

@fupengl fupengl reopened this Sep 19, 2022
@JamesHenry
Copy link
Member

@fupengl ok cool thanks, I wondering if it might turn out to be a pnpm thing... We can definitely merge this once it's green

@JamesHenry JamesHenry merged commit 068830e into lerna:main Sep 19, 2022
@fupengl
Copy link
Contributor Author

fupengl commented Sep 20, 2022

If it is a case of non-dependent promotion, it needs to be solved by lerna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants