Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prevent validation error in version/publish with workspace: prefix #3322

Merged
merged 1 commit into from Sep 8, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Sep 7, 2022

Description

Prevents the validation error when the Package Graph is constructed without all of the dependencies listed by all packages.

This PR also removes an unused function from the package-graph unit tests.

Motivation and Context

During the changelog update of version and publish, the package graph is constructed with only the changed packages, so it can't make assumptions based on the existence of other packages in the workspace. In short, there is not enough information to properly validate what the validation error was asserting in all use cases of PackageGraph.

#3317

How Has This Been Tested?

This change reverts a previously-added validation error. Tests checking for that validation error have been removed and all other unit/integration/e2e tests have passed. Lerna version and publish have also been run manually to verify that this change solves the issue above.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review September 7, 2022 20:55
@JamesHenry JamesHenry changed the title fix(core): Prevent validation error in Version / Publish with workspace: prefix fix(core): prevent validation error in version/publish with workspace: prefix Sep 8, 2022
@JamesHenry JamesHenry merged commit 746ce33 into lerna:main Sep 8, 2022
@fahslaj fahslaj deleted the 3317-remove-local-check branch September 15, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants