fix(core): prevent validation error in version/publish with workspace:
prefix
#3322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents the validation error when the Package Graph is constructed without all of the dependencies listed by all packages.
This PR also removes an unused function from the package-graph unit tests.
Motivation and Context
During the changelog update of
version
andpublish
, the package graph is constructed with only the changed packages, so it can't make assumptions based on the existence of other packages in the workspace. In short, there is not enough information to properly validate what the validation error was asserting in all use cases of PackageGraph.#3317
How Has This Been Tested?
This change reverts a previously-added validation error. Tests checking for that validation error have been removed and all other unit/integration/e2e tests have passed. Lerna version and publish have also been run manually to verify that this change solves the issue above.
Types of changes
Checklist: