feat(repair): add lerna repair command #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
force-pushed
the
lerna-repair-2
branch
from
e69d1e8
to
0ca2d46
Compare
fahslaj
reviewed
Sep 1, 2022
| @@ -49,7 +49,10 @@ class Command { | |||
| chain = chain.then(() => this.configureOptions()); | |||
| chain = chain.then(() => this.configureProperties()); | |||
| chain = chain.then(() => this.configureLogging()); | |||
| chain = chain.then(() => this.runValidations()); | |||
| // For the special "repair" command we want to intitialize everything but don't want to run validations as that will end up becoming cyclical | |||
There was a problem hiding this comment.
Type: "intitialize" -> "initialize"
|
Resolved |
JamesHenry
force-pushed
the
lerna-repair-2
branch
from
0ca2d46
to
81c660b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new command:
lerna repair. This command will run any available migrations which have been designed to bring a lerna workspace up to date with the latest and greatest.This PR does not ship with a real implementation of such a migration, so instead a
noopexample migration is provided to concretely illustrate how a migration is both written and unit tested within thelernapackage.NOTE: the implementation for the
repaircommand is intentionally inlined into thelernapackage. Because of the way migrations are orchestrated, havingrepairbe its own package would result in a cyclical dependency between it and the core package. Plus, in general, we are not looking to continue with the pattern of having an ever-increasing number of tiny published packages.Types of changes
Checklist: