Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): update package-lock at the root if it exists #3290

Merged
merged 2 commits into from Aug 14, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Aug 12, 2022

Description

Updates the package-lock file in the root after running lerna version.

Motivation and Context

This removes the need to manually update the package lock file after a new version is tagged.

How Has This Been Tested?

I have tested this manually on the lerna repo itself. It is also covered by end to end tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review August 12, 2022 21:09
@JamesHenry JamesHenry changed the title fix(version): update package-lock in the root if exists fix(version): update package-lock in the root if it exists Aug 14, 2022
@JamesHenry JamesHenry changed the title fix(version): update package-lock in the root if it exists fix(version): update package-lock at the root if it exists Aug 14, 2022
@JamesHenry JamesHenry merged commit 7f62bab into lerna:main Aug 14, 2022
@fahslaj fahslaj deleted the version-update-lockfile branch August 15, 2022 14:49
@audunru
Copy link

audunru commented Sep 15, 2022

This seems to remove all entries from the root package-lock.json that bootstrapping with hoisting adds to the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants