Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): Default test script no longer errors #3266

Merged
merged 5 commits into from Jul 28, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jul 27, 2022

When running lerna create, the generated files will now include a test that is actually runnable via lerna run test.

Description

Motivation and Context

Before this change, running lerna run test on a newly created package would produce an error that told the user to "run tests from the root", which makes no sense. This change improves developer experience when using lerna create by leaving the user's workspace in a runnable state immediately after package creation.

How Has This Been Tested?

This has been tested manually, with and without --es-module, on a test lerna workspace. New unit tests have also been added as well as existing ones updated appropriately.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review July 27, 2022 21:28
@fahslaj fahslaj requested a review from JamesHenry July 27, 2022 21:28
@JamesHenry JamesHenry merged commit dfd30fa into lerna:main Jul 28, 2022
@fahslaj fahslaj deleted the add-real-test-with-create branch July 29, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants