New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(init): default useNx and useWorkspaces to true for new lerna workspaces #3255
Merged
JamesHenry
merged 11 commits into
lerna:main
from
fahslaj:lerna-init-default-useNx-useWorkspaces-true
Jul 22, 2022
Merged
feat(init): default useNx and useWorkspaces to true for new lerna workspaces #3255
JamesHenry
merged 11 commits into
lerna:main
from
fahslaj:lerna-init-default-useNx-useWorkspaces-true
Jul 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahslaj
commented
Jul 22, 2022
fahslaj
force-pushed
the
lerna-init-default-useNx-useWorkspaces-true
branch
from
July 22, 2022 14:50
e5cee67
to
334cf6a
Compare
fahslaj
force-pushed
the
lerna-init-default-useNx-useWorkspaces-true
branch
from
July 22, 2022 15:14
334cf6a
to
97d36a1
Compare
JamesHenry
changed the title
feat: Lerna init default useNx and useWorkspaces to true
feat(init): default useNx and useWorkspaces to true for new lerna workspaces
Jul 22, 2022
JamesHenry
requested changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per slack discussion
JamesHenry
approved these changes
Jul 22, 2022
This installs Even stuff that I wouldn't expect like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing lerna for the first time with
lerna init
, workspaces and nx will both be enabled by default.Description
For lerna init:
For all commands:
For the docs:
For
lerna --help
Motivation and Context
This change enables two of lerna's most powerful features by default - the ability to run commands with nx and the ability to make use of Yarn/npm workspaces by default for detecting packages.
How Has This Been Tested?
Extensive unit, integration, and e2e tests have been added. I have also manually tested the lerna init command for each of these scenarios.
Types of changes
Checklist: