New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(run): add double quotes around script target containing colon #3218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @brees-worth!
Please kindly fix up the CI and also add some coverage for this in our new (WIP) e2e tests:
e2e/tests/lerna-run/lerna-run.spec.ts
To run the e2e tests you just run:
npm run e2e
You can also forward any arguments onto jest you want, e.g. to only run the lerna-run tests
npm run e2e -- lerna-run.spec.ts
All done |
Thanks a lot @brees-worth this is a good case to have in there, but you haven't actually covered the case you are affecting with this change. Your change is affecting the run-one case, so we need an additional test in there which only invokes the script target for a single project. Please kindly add coverage for a single target script with and without a Many thanks again! |
This is harder than my day job ;) Fair suggestions, though. |
Thank you @brees-worth! |
Description
Adds double-quotes around script target when running with Nx.
Closes #3215
Motivation and Context
Issue #3215
References issue in Nx
How Has This Been Tested?
New unit test added to test suite for command/run. Tested with node 16, npm 8
Types of changes
Checklist: