Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(version): support custom command for git tag #2760

Merged
merged 3 commits into from Dec 23, 2022
Merged

feat(version): support custom command for git tag #2760

merged 3 commits into from Dec 23, 2022

Conversation

evangelion1204
Copy link
Contributor

@evangelion1204 evangelion1204 commented Nov 16, 2020 •
edited

Description

Added support to override the executed command for git tag via CLI options and lerna.json entry.

Motivation and Context

Some CD/CI systems have no direct write access to the repository and are not able to tag the normal way via git. An optional wrapper command/alias might be defined.

How Has This Been Tested?

  • Added unit-tests
  • ./core/lerna/cli.js version -h shows new option

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evangelion1204 evangelion1204 force-pushed the flexible-commands branch 4 times, most recently from e4ea105 to 2eecc49 Compare November 17, 2020 13:11
leandrobudau
leandrobudau previously approved these changes Dec 14, 2020
View reviewed changes
@evangelion1204
Copy link
Contributor Author

Rebased but now a lot of checks are failing incl. tests. Anything changed recently?

@JamesHenry
Copy link
Member

Hi @evangelion1204 I'm sorry for how long this PR sat in limbo. Do you have time to bring it up to date with the latest?

@evangelion1204
Copy link
Contributor Author

Thanks a lot for the feedback. Will rebase the PR the next days.

@evangelion1204 evangelion1204 force-pushed the flexible-commands branch 3 times, most recently from 73462c5 to 1ecab55 Compare December 19, 2022 08:06
@evangelion1204
Copy link
Contributor Author

@JamesHenry Feel free to approve the pipeline once more. Should be passing now. Missed the format command. I am just too used to run prettier myself on each save.

@evangelion1204
Copy link
Contributor Author

I am not sure why this test fails, "locally" it works test and integration but I don't understand what exactly fails with the pipeline.

@evangelion1204 evangelion1204 force-pushed the flexible-commands branch 2 times, most recently from ae8dfeb to 273ea8b Compare December 20, 2022 08:14
LCFAP-7035
c93ea5d 
Custom command for git-tag
@evangelion1204
Copy link
Contributor Author

Reverted my changed of .gitignore that might have caused the issue.

@JamesHenry
Copy link
Member

JamesHenry commented Dec 20, 2022 •
edited

@evangelion1204 i think it was just some flakiness in the e2e

Please don’t force push any more now that this PR is actively being reviewed, it nukes the history.

The PR will be squash merged anyway

@evangelion1204
Copy link
Contributor Author

@JamesHenry will do so, I am just used to manual squashing. Will keep it in mind for the future.

@JamesHenry
Copy link
Member

Thanks! I'll keep rerunning this for now to see if it's just flakiness

JamesHenry
JamesHenry reviewed Dec 23, 2022
View reviewed changes
commands/version/README.md Outdated Show resolved Hide resolved
commands/version/command.js Outdated Show resolved Hide resolved
@JamesHenry JamesHenry changed the title Support custom command for git-tag feat(version): support custom command for git tag Dec 23, 2022
JamesHenry
JamesHenry previously approved these changes Dec 23, 2022
View reviewed changes
@JamesHenry JamesHenry enabled auto-merge (squash) December 23, 2022 12:01
@JamesHenry JamesHenry merged commit 6eac92f into lerna:main Dec 23, 2022
@JamesHenry
Copy link
Member

Thanks again @evangelion1204!

@ghiscoding ghiscoding mentioned this pull request Dec 23, 2022
Merged
9 tasks
@evangelion1204 evangelion1204 deleted the flexible-commands branch April 17, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@leandrobudau leandrobudau leandrobudau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evangelion1204 @JamesHenry @leandrobudau