Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Add new info command to output information about local environment #2106

Merged
merged 11 commits into from Dec 15, 2019
Merged

feat(cli): Add new info command to output information about local environment #2106

merged 11 commits into from Dec 15, 2019

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented May 23, 2019 •
edited

Description

Added lerna info command which prints local environment information.

Motivation and Context

Closes #2097

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jamesgeorge007 jamesgeorge007 mentioned this pull request May 23, 2019
Closed
evocateur
evocateur suggested changes Jun 9, 2019
View reviewed changes
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, sorry for the delay in reviewing.

commands/info/package.json Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
commands/info/__tests__/info-command.test.js Outdated Show resolved Hide resolved
commands/info/index.js Show resolved Hide resolved
commands/info/index.js Show resolved Hide resolved
commands/info/index.js Outdated Show resolved Hide resolved
evocateur
evocateur suggested changes Jul 18, 2019
View reviewed changes
commands/info/index.js Show resolved Hide resolved
commands/info/index.js Outdated Show resolved Hide resolved
commands/info/__tests__/info-command.test.js Outdated Show resolved Hide resolved
core/lerna/package.json Show resolved Hide resolved
evocateur
evocateur suggested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the json error in the lockfile, looks much better, thanks!

package-lock.json Show resolved Hide resolved
@jamesgeorge007 jamesgeorge007 changed the title feat(cli): added info command feat(cli): new info command which shows up local-env information Nov 11, 2019
evocateur
evocateur suggested changes Nov 20, 2019
View reviewed changes
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go once tests pass in CI

commands/info/__tests__/info-command.test.js Show resolved Hide resolved
@evocateur evocateur changed the title feat(cli): new info command which shows up local-env information feat(cli): Add new info command to output envinfo Dec 15, 2019
@evocateur evocateur changed the title feat(cli): Add new info command to output envinfo feat(cli): Add new info command to output information about local environment Dec 15, 2019
@evocateur evocateur merged commit 7abfe43 into lerna:master Dec 15, 2019
@jamesgeorge007 jamesgeorge007 deleted the feat/info-cmd branch December 16, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evocateur evocateur evocateur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having a dedicated info command to print out the local environment information
2 participants
@jamesgeorge007 @evocateur