From e519f43049253e66c1ab840c3c08435be1477d76 Mon Sep 17 00:00:00 2001 From: James Henry Date: Mon, 13 Jun 2022 14:15:31 +0400 Subject: [PATCH] fix(conventional-commits): remove pinned lodash.template (#3172) --- CONTRIBUTING.md | 4 +-- core/conventional-commits/package.json | 1 - e2e/publish-to-verdaccio.sh | 2 +- package-lock.json | 47 -------------------------- package.json | 3 +- 5 files changed, 4 insertions(+), 53 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 713c189045..3e525a0991 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -103,12 +103,12 @@ If you want to test out Lerna on local repos, you can leverage verdaccio as a lo Open a new terminal window and run the following from the root of the workspace: ```sh -$ npx lerna run --scope @lerna/e2e start-verdaccio +npx lerna run --scope @lerna/e2e start-verdaccio ``` This will run verdaccio on http://localhost:4872 -In another terminal window you can now publish any new version (in this example `999.9.9`) to that local registry: +In another terminal window you can now build and publish any new version (in this example `999.9.9`) to that local registry: ```sh npm run e2e:local-publish -- 999.9.9 diff --git a/core/conventional-commits/package.json b/core/conventional-commits/package.json index 80e56682fd..dd69e3cc68 100644 --- a/core/conventional-commits/package.json +++ b/core/conventional-commits/package.json @@ -38,7 +38,6 @@ "conventional-recommended-bump": "^6.1.0", "fs-extra": "^9.1.0", "get-stream": "^6.0.0", - "lodash.template": "^4.5.0", "npm-package-arg": "^8.1.0", "npmlog": "^6.0.2", "pify": "^5.0.0", diff --git a/e2e/publish-to-verdaccio.sh b/e2e/publish-to-verdaccio.sh index d9cd90ab11..6ef08fd7e7 100755 --- a/e2e/publish-to-verdaccio.sh +++ b/e2e/publish-to-verdaccio.sh @@ -24,7 +24,7 @@ fi # Change to the prepared dist directory cd ../dist -echo "Updating the package versions in $(pwd)/dist to use $VERSION" +echo "Updating the package versions in $(pwd) to use $VERSION" echo "" diff --git a/package-lock.json b/package-lock.json index 422049ae73..731f91c769 100644 --- a/package-lock.json +++ b/package-lock.json @@ -46,7 +46,6 @@ "libnpmaccess": "^4.0.1", "libnpmpublish": "^4.0.0", "load-json-file": "^6.2.0", - "lodash.template": "^4.5.0", "minimatch": "^3.0.4", "multimatch": "^5.0.0", "node-fetch": "^2.6.1", @@ -525,7 +524,6 @@ "conventional-recommended-bump": "^6.1.0", "fs-extra": "^9.1.0", "get-stream": "^6.0.0", - "lodash.template": "^4.5.0", "npm-package-arg": "^8.1.0", "npmlog": "^6.0.2", "pify": "^5.0.0", @@ -12474,11 +12472,6 @@ "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.21.tgz", "integrity": "sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==" }, - "node_modules/lodash._reinterpolate": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/lodash._reinterpolate/-/lodash._reinterpolate-3.0.0.tgz", - "integrity": "sha1-DM8tiRZq8Ds2Y8eWU4t1rG4RTZ0=" - }, "node_modules/lodash.includes": { "version": "4.3.0", "resolved": "https://registry.npmjs.org/lodash.includes/-/lodash.includes-4.3.0.tgz", @@ -12531,23 +12524,6 @@ "resolved": "https://registry.npmjs.org/lodash.sortby/-/lodash.sortby-4.7.0.tgz", "integrity": "sha1-7dFMgk4sycHgsKG0K7UhBRakJDg=" }, - "node_modules/lodash.template": { - "version": "4.5.0", - "resolved": "https://registry.npmjs.org/lodash.template/-/lodash.template-4.5.0.tgz", - "integrity": "sha512-84vYFxIkmidUiFxidA/KjjH9pAycqW+h980j7Fuz5qxRtO9pgB7MDFTdys1N7A5mcucRiDyEq4fusljItR1T/A==", - "dependencies": { - "lodash._reinterpolate": "^3.0.0", - "lodash.templatesettings": "^4.0.0" - } - }, - "node_modules/lodash.templatesettings": { - "version": "4.2.0", - "resolved": "https://registry.npmjs.org/lodash.templatesettings/-/lodash.templatesettings-4.2.0.tgz", - "integrity": "sha512-stgLz+i3Aa9mZgnjr/O+v9ruKZsPsndy7qPZOchbqk2cnTU1ZaldKK+v7m54WoKIyxiuMZTKT2H81F8BeAc3ZQ==", - "dependencies": { - "lodash._reinterpolate": "^3.0.0" - } - }, "node_modules/loud-rejection": { "version": "1.6.0", "resolved": "https://registry.npmjs.org/loud-rejection/-/loud-rejection-1.6.0.tgz", @@ -20944,7 +20920,6 @@ "conventional-recommended-bump": "^6.1.0", "fs-extra": "^9.1.0", "get-stream": "^6.0.0", - "lodash.template": "^4.5.0", "npm-package-arg": "^8.1.0", "npmlog": "^6.0.2", "pify": "^5.0.0", @@ -29368,11 +29343,6 @@ "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.21.tgz", "integrity": "sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==" }, - "lodash._reinterpolate": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/lodash._reinterpolate/-/lodash._reinterpolate-3.0.0.tgz", - "integrity": "sha1-DM8tiRZq8Ds2Y8eWU4t1rG4RTZ0=" - }, "lodash.includes": { "version": "4.3.0", "resolved": "https://registry.npmjs.org/lodash.includes/-/lodash.includes-4.3.0.tgz", @@ -29425,23 +29395,6 @@ "resolved": "https://registry.npmjs.org/lodash.sortby/-/lodash.sortby-4.7.0.tgz", "integrity": "sha1-7dFMgk4sycHgsKG0K7UhBRakJDg=" }, - "lodash.template": { - "version": "4.5.0", - "resolved": "https://registry.npmjs.org/lodash.template/-/lodash.template-4.5.0.tgz", - "integrity": "sha512-84vYFxIkmidUiFxidA/KjjH9pAycqW+h980j7Fuz5qxRtO9pgB7MDFTdys1N7A5mcucRiDyEq4fusljItR1T/A==", - "requires": { - "lodash._reinterpolate": "^3.0.0", - "lodash.templatesettings": "^4.0.0" - } - }, - "lodash.templatesettings": { - "version": "4.2.0", - "resolved": "https://registry.npmjs.org/lodash.templatesettings/-/lodash.templatesettings-4.2.0.tgz", - "integrity": "sha512-stgLz+i3Aa9mZgnjr/O+v9ruKZsPsndy7qPZOchbqk2cnTU1ZaldKK+v7m54WoKIyxiuMZTKT2H81F8BeAc3ZQ==", - "requires": { - "lodash._reinterpolate": "^3.0.0" - } - }, "loud-rejection": { "version": "1.6.0", "resolved": "https://registry.npmjs.org/loud-rejection/-/loud-rejection-1.6.0.tgz", diff --git a/package.json b/package.json index 80fc52fe22..523da5502c 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,7 @@ "ci:windows": "jest --ci --maxWorkers=2 && npm run integration -- --ci", "build": "scripts/build.sh", "e2e": "npm run build && npx lerna run --scope @lerna/e2e e2e", - "e2e:local-publish": "npm run --workspace e2e publish-to-verdaccio", + "e2e:local-publish": "npm run build && npm run --workspace e2e prepare-local-publish && npm run --workspace e2e publish-to-verdaccio", "fix": "npm run lint -- --fix", "integration": "jest --config jest.integration.js --maxWorkers=2", "ci:lint": "eslint . -c .eslintrc.yaml --no-eslintrc --ignore-path .gitignore", @@ -71,7 +71,6 @@ "libnpmaccess": "^4.0.1", "libnpmpublish": "^4.0.0", "load-json-file": "^6.2.0", - "lodash.template": "^4.5.0", "minimatch": "^3.0.4", "multimatch": "^5.0.0", "node-fetch": "^2.6.1",