From 7e69e9e308ec36d1c7b9682673e785aaa4ce056a Mon Sep 17 00:00:00 2001 From: James Henry Date: Tue, 7 Jun 2022 20:15:33 +0400 Subject: [PATCH] fix(utils): orphaned child process on Windows (#3156) Co-authored-by: Fery Wardiyanto --- utils/npm-run-script/__tests__/npm-run-script.test.js | 5 +++++ utils/npm-run-script/npm-run-script.js | 1 + 2 files changed, 6 insertions(+) diff --git a/utils/npm-run-script/__tests__/npm-run-script.test.js b/utils/npm-run-script/__tests__/npm-run-script.test.js index aba6a090bc..2d1c71e965 100644 --- a/utils/npm-run-script/__tests__/npm-run-script.test.js +++ b/utils/npm-run-script/__tests__/npm-run-script.test.js @@ -30,6 +30,7 @@ describe("npm-run-script", () => { env: {}, pkg: config.pkg, reject: true, + windowsHide: false, }); }); @@ -51,6 +52,7 @@ describe("npm-run-script", () => { env: {}, pkg: config.pkg, reject: false, + windowsHide: false, }); }); @@ -71,6 +73,7 @@ describe("npm-run-script", () => { env: {}, pkg: config.pkg, reject: true, + windowsHide: false, }); }); }); @@ -98,6 +101,7 @@ describe("npm-run-script", () => { env: {}, pkg: config.pkg, reject: true, + windowsHide: false, }, config.pkg.name ); @@ -125,6 +129,7 @@ describe("npm-run-script", () => { env: {}, pkg: config.pkg, reject: false, + windowsHide: false, }, undefined ); diff --git a/utils/npm-run-script/npm-run-script.js b/utils/npm-run-script/npm-run-script.js index 0f51afd207..4147b52c98 100644 --- a/utils/npm-run-script/npm-run-script.js +++ b/utils/npm-run-script/npm-run-script.js @@ -28,6 +28,7 @@ function npmRunScriptStreaming(script, { args, npmClient, pkg, prefix, reject = function makeOpts(pkg, reject) { return Object.assign(getNpmExecOpts(pkg), { + windowsHide: false, reject, }); }