Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix husky and lint-staged issues #123

Closed
niloysikdar opened this issue Oct 15, 2022 · 1 comment · Fixed by #126
Closed

[CI] Fix husky and lint-staged issues #123

niloysikdar opened this issue Oct 15, 2022 · 1 comment · Fixed by #126
Assignees
@niloysikdar
Labels
bug Something isn't working hacktoberfest This is included under Hacktoberfest released

Comments

@niloysikdar
Copy link
Member

niloysikdar commented Oct 15, 2022 •
edited

Description:

Currently, if we try to commit anything then the pre-commit git hook will automatically get triggered using Husky. Now it runs the yarn lint-staged command to check the lining rules of the code from the staged files. If we try to run the yarn lint-staged command normally after git add, it works fine. But when it runs inside an environment like husky, it will continuously produce an excess amount of the same logs, which blows up the terminal/cmd.

Additional Info

OS: Windows 10
husky Version: 8.0.0
lint-staged version: 13.0.2

References:

Also, we can remove git add -A . from the pre-commit hook after yarn lint-staged.
@niloysikdar niloysikdar added bug Something isn't working hacktoberfest This is included under Hacktoberfest labels Oct 15, 2022
@niloysikdar niloysikdar changed the title [CI] Fix Husky issues [CI] Fix husky and lint-staged issues Oct 15, 2022
@niloysikdar niloysikdar self-assigned this Oct 15, 2022
niloysikdar added a commit that referenced this issue Oct 15, 2022
@niloysikdar
ci(lint-staged): fix husky and lint-staged issues
b0dc0fa 
Fix the excess amount of the same logs, which blows up the terminal/cmd on windows while running
lint-staged from husky

Fixes #123

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Oct 15, 2022
Merged
niloysikdar added a commit that referenced this issue Oct 17, 2022
@niloysikdar
ci(lint-staged): fix husky and lint-staged issues (#126)
81a24ac 
Fix the excess amount of the same logs, which blows up the terminal/cmd on windows while running
lint-staged from husky

Fixes #123

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@github-actions
Copy link

🎉 This PR is included in version 1.15.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
bug Something isn't working hacktoberfest This is included under Hacktoberfest released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(lint-staged): fix husky and lint-staged issues leopardslab/react-email
1 participant
@niloysikdar