Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ]: Incomplete Architecture Support #71

Closed
1 task done
petrandr opened this issue Jul 14, 2023 · 2 comments
Closed
1 task done

[ BUG ]: Incomplete Architecture Support #71

petrandr opened this issue Jul 14, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@petrandr
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently, the installation script (deps.sh) for the gh CLI only supports one architecture amd64.

This means that users on other architectures e.g. arm64 will not be able to use this automation.

Follows an example output while running the automation on an arm64 runner.

##[debug]/usr/bin/bash --noprofile --norc -e -o pipefail /home/ubuntu/actions-runner/_work/_temp/2d452a82-5f81-4399-8230-7d5468c9a0cc.sh
/home/ubuntu/actions-runner/_work/_temp/2d452a82-5f81-4399-8230-7d5468c9a0cc.sh: line 1: /usr/local/bin/gh: cannot execute binary file: Exec format error
Error: Process completed with exit code 126.

This occurs because the dep.sh installed the wrong arch version (amd64) of the gh cli on an arm64 system.

Expected Behavior

It is important to enhance the installation script to support a wider range of architectures. By doing so, we can ensure that users on various systems can easily use this automation without encountering architecture-related issues.

The expected behaviour is to extend the script to include support for the aarch64 architecture (for now).

With expanded architecture support, the installation script will automatically detect the system architecture and download the appropriate gh CLI binary for seamless installation.

Version

v1.0.2

Which github actions runner are you using?

Linux

Steps To Reproduce

  1. Install GitHub Runner on an arm-based system
  2. Register the runner in your account
  3. Use the automation

Relevant log output

##[debug]/usr/bin/bash --noprofile --norc -e -o pipefail /home/ubuntu/actions-runner/_work/_temp/2d452a82-5f81-4399-8230-7d5468c9a0cc.sh
/home/ubuntu/actions-runner/_work/_temp/2d452a82-5f81-4399-8230-7d5468c9a0cc.sh: line 1: /usr/local/bin/gh: cannot execute binary file: Exec format error
Error: Process completed with exit code 126.


### Additional context:

_No response_
@petrandr petrandr added the bug Something isn't working label Jul 14, 2023
@leonsteinhaeuser
Copy link
Owner

Thank you for this report. Indeed, the support of multiple architectures was not planned at that time. I have seen that you have already taken responsibility for the implementation of this feature.

@leonsteinhaeuser
Copy link
Owner

@petrandr this functionality has been release with version v2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants