Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies update #63

Merged
merged 2 commits into from Apr 25, 2022
Merged

Dependencies update #63

merged 2 commits into from Apr 25, 2022

Conversation

vorlif
Copy link
Contributor

@vorlif vorlif commented Apr 24, 2022

Is this a fix, improvement or something else?

Fix and improvement

What does this change implement/fix?

Whenever I try to run xgotext I get an error message:

./xgotext -in fixtures/ -out fixtures/i18n/

internal error: package "errors" without types was imported from "github.com/leonelquinteros/gotext/cli/xgotext/fixtures"

I found this issue and it was recommended to update golang.org/x/tools to an newer version. After doing this, I was able to use xgotext without any problems. I have therefore updated all dependencies.

I also removed dep from the readme as it was marked as deprecated and the repository was archived.

Can we set the minimum Go version to 1.16? https://endoflife.date/go

I have ...

  • answered the 2 questions above,
  • discussed this change in an issue,
  • included tests to cover this changes.

@leonelquinteros leonelquinteros merged commit c7fb758 into leonelquinteros:master Apr 25, 2022
@vorlif vorlif deleted the deps-update branch April 25, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants