Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage dropped when Coverage didn't change #1746

Open
jcubic opened this issue Jan 19, 2024 · 0 comments
Open

Coverage dropped when Coverage didn't change #1746

jcubic opened this issue Jan 19, 2024 · 0 comments

Comments

@jcubic
Copy link

jcubic commented Jan 19, 2024

In this commit:

LIPS-scheme/lips@28a58e6

I've added this code:

    dot = true;
} else if (dot) {
    throw new Error('Parser: syntax error more than one element after dot');
} else {

The code was tested and it's covered by tests, because I checked the JSON file generated by C8 and the lines are green. But Coveralls said that Coverage dropped by -0.02%

https://coveralls.io/builds/65153629

In the same, I deleted one line of code and Coveralls said that the Coverage dropped by 0.002%

https://coveralls.io/builds/65177310

Another example I've updated dependencies and Coverage dropped by 0.3%

https://coveralls.io/builds/65163814

It looks like reports are Random. Can you explain the dropping of Coverage?

This is my coverage status:

----------|---------|----------|---------|---------|
File      | % Stmts | % Branch | % Funcs | % Lines |
----------|---------|----------|---------|---------|
All files |   85.36 |    86.84 |   83.97 |   85.36 |
 lips.js  |   85.36 |    86.84 |   83.97 |   85.36 |
----------|---------|----------|---------|---------|

Not sure why I have 85.669%.

EDIT: Another issue is reverse, the code was added that was fully Tested and Coveralls says that the Coverage increased by 0.02% but nothing changed:

https://coveralls.io/builds/65485219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant