Consider merging the functionality of the node.Node proxy into the concrete ast.Node #80
Labels
Comments
lelit
added a commit
that referenced
this issue
May 28, 2022
This is the first step to implement issue #80, making it easier to get rid of the old Node wrappers, whose main functionality in v3 was to keep track of the "parent_node"/"parent_member" information.
lelit
added a commit
that referenced
this issue
May 28, 2022
Those wrappers were needed in v1 to hide the underlying JSON structures emitted by libpg_query, making it possible to see them as generic Python instances. Version 3 obsoleted that by introducing a set of concrete AST classes, and the wrappers were kept mainly for their ability to track the parentship of each node, required by some of the printer functions. Now they are gone, and everything works directly on AST classes, and the printers use the new "ancestors" slot attached to each instance. This implements issue #80.
|
Done in v4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The proxy has been there since the beginning, because in v1 it dealt with the
JSONstructure returned by libpg_query'sparse_sql()function.Now that there is a set of concrete
astclasses, maybe it would make sense to move the hierarchy tracking data (parent_nodeandparent_attribute) into the concrete nodes.Will think about this for v4.
The text was updated successfully, but these errors were encountered: