Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests and gherkin stories still needed for #6865 #6904

Closed
jamalex opened this issue May 21, 2020 · 4 comments · Fixed by #7358
Closed

Automated tests and gherkin stories still needed for #6865 #6904

jamalex opened this issue May 21, 2020 · 4 comments · Fixed by #7358
Labels
P1 - important Priority: High impact on UX TAG: tech update / debt Change not visible to user
Milestone

Comments

@jamalex
Copy link
Member

jamalex commented May 21, 2020

We didn't have time to do automated tests or gherkin stories for #6865 -- but if would be good to have these before this ships in 0.14, even if it's still a hidden feature at that point.

@jamalex jamalex added the TAG: tech update / debt Change not visible to user label May 21, 2020
@jamalex jamalex added this to the 0.14.0 milestone May 21, 2020
@indirectlylit indirectlylit added the P1 - important Priority: High impact on UX label May 21, 2020
@indirectlylit
Copy link
Contributor

cc @jamalex

@radinamatic
Copy link
Member

@jamalex Does this Gherkin by @kollivier covers all that needs to be tested?

@jamalex
Copy link
Member Author

jamalex commented Jul 16, 2020

That looks good, yep! There may be some more nuanced stuff around rescanning etc, but we need to think more about how we might do scanning in the first place. For the current functionality, this seems fine.

@jamalex jamalex closed this as completed Jul 16, 2020
@radinamatic
Copy link
Member

Awesome, thank you, will open the PR to transfer the Gherkin to the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX TAG: tech update / debt Change not visible to user
Projects
None yet
3 participants