Linux: remove misleading C++-style default values #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if `window_manager_plugin.cc` is compiled as C++, C++-style inline initialization of struct members doesn't work for `_WindowManagerPlugin` because the instance is not created by the C++ operator new but alloc'd and zero-filled by the GObject type system. > GObject explicitly guarantees that all class and instance members > (except the fields pointing to the parents) to be set to zero. https://docs.gtk.org/gobject/concepts.html#object-instantiation Initial values can be set in `window_manager_plugin_init()` if needed.
obiwanzenobi
pushed a commit
to obiwanzenobi/window_manager
that referenced
this pull request
May 25, 2023
Even if `window_manager_plugin.cc` is compiled as C++, C++-style inline initialization of struct members doesn't work for `_WindowManagerPlugin` because the instance is not created by the C++ operator new but alloc'd and zero-filled by the GObject type system. > GObject explicitly guarantees that all class and instance members > (except the fields pointing to the parents) to be set to zero. https://docs.gtk.org/gobject/concepts.html#object-instantiation Initial values can be set in `window_manager_plugin_init()` if needed. Co-authored-by: LiJianying <lijy91@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if
window_manager_plugin.ccis compiled as C++, C++-style inline initialization of struct members doesn't work for_WindowManagerPluginbecause the instance is not created by the C++ operator new but alloc'd and zero-filled by the GObject type system.https://docs.gtk.org/gobject/concepts.html#object-instantiation
Initial values can be set in
window_manager_plugin_init()if needed.