New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: fix frameless window & background color #250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Must not be called for HdyWindow or it won't render the background.
lijy91
pushed a commit
that referenced
this pull request
Jan 3, 2023
* [linux] clean up unused includes - cairo is unused since #250 - utsname and cstring are leftovers from the flutter plugin template * [linux] change the last remaining strcmp() to g_strcmp0() While one PR was changing strcmp()'s to g_strcmp0(), this piece of code was added in another PR. Use the same method here as well, just for the sake of aesthetics and consistency.
obiwanzenobi
pushed a commit
to obiwanzenobi/window_manager
that referenced
this pull request
May 25, 2023
* Linux: fix frameless window & background color * Remove gtk_widget_set_app_paintable() Must not be called for HdyWindow or it won't render the background. * Add window selector Co-authored-by: LiJianying <lijy91@foxmail.com>
obiwanzenobi
pushed a commit
to obiwanzenobi/window_manager
that referenced
this pull request
May 25, 2023
* [linux] clean up unused includes - cairo is unused since leanflutter#250 - utsname and cstring are leftovers from the flutter plugin template * [linux] change the last remaining strcmp() to g_strcmp0() While one PR was changing strcmp()'s to g_strcmp0(), this piece of code was added in another PR. Use the same method here as well, just for the sake of aesthetics and consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement of #248 and implements support for frameless windows and background colors in a way that it doesn't draw over HdyWindow's shadows nor needs any redraw tricks.